Skip to content

fix: Stop hardcoding dependency versions - #4695

Merged
svartkanin merged 1 commit into
archlinux:masterfrom
C0rn3j:patch-1
Aug 11, 2026
Merged

fix: Stop hardcoding dependency versions#4695
svartkanin merged 1 commit into
archlinux:masterfrom
C0rn3j:patch-1

Conversation

@C0rn3j

@C0rn3j C0rn3j commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #4694

PR Description:

Stop hardcoding versions of packages and allow new versions too, fixes pip check failing.

Tests and Checks

  • I have tested the code!

@C0rn3j
C0rn3j requested a review from Torxed as a code owner August 4, 2026 00:25

@codefiles codefiles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break Renovate without changing == to >= in these as well:

"matchStrings": [
"\"(?<depName>pyparted|pydantic|cryptography|textual|markdown-it-py|linkify-it-py)==(?<currentValue>[^\"]+)\""
],

"matchStrings": [
"\"systemd_python==(?<currentValue>[^\"]+)\""
],

@svartkanin

Copy link
Copy Markdown
Collaborator

@C0rn3j could you address the comment

@C0rn3j

C0rn3j commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Fixed now.

Note that if it is desired to have a known-good suite of packages (and not conflict with actual package managers), one can use a optional-dependencies group, which will work as long as the default deps and the optional ones do not conflict

i.e dep>=1.1 + dep==1.0 is bad, but the following is fine:

[project]
dependencies = [
	"evdev>=1.9.0",
]

[project.optional-dependencies]
tested = [
	"evdev==1.9.1",
]

Users would then need to be instructed to install via:
pip install "archinstall[tested]" or pip install ".[tested]" if running from source.

That way a newly released broken dep won't break pre-existing archinstall versions on PyPI.

If there's interest in that I can amend the changes to include that too, if not, can be pulled as is.

The dev deps don't make sense to version fix in any case.

@svartkanin
svartkanin merged commit d571283 into archlinux:master Aug 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop hardcoding exact versions in pyproject.toml

3 participants